Can't add new command when connection is in closed state

Issue type:

[ ] question [x ] bug report [ ] feature request [ ] documentation issue

Database system/driver:

[ ] cordova [ ] mongodb [ ] mssql [x] mysql / mariadb [ ] oracle [ ] postgres [ ] cockroachdb [ ] sqlite [ ] sqljs [ ] react-native [ ] expo

TypeORM version:

[ ] latest [ ] @next [x] ^0.2.18 (or put your version here)

Steps to reproduce or a small repository showing the problem:

{ QueryFailedError: Can't add new command when connection is in closed state
 |        at new QueryFailedError (/usr/src/my-app/src/error/QueryFailedError.ts:9:9)
 |        at Query.onResult (/usr/src/my-app/src/driver/mysql/MysqlQueryRunner.ts:166:37)
 |        at PoolConnection._addCommandClosedState (/usr/src/my-app/node_modules/mysql2/lib/connection.js:139:11)
 |        at PoolConnection.query (/usr/src/my-app/node_modules/mysql2/lib/connection.js:534:17)
 |        at MysqlQueryRunner.<anonymous> (/usr/src/my-app/src/driver/mysql/MysqlQueryRunner.ts:155:36)
 |        at step (/usr/src/my-app/node_modules/tslib/tslib.js:136:27)
 |        at Object.next (/usr/src/my-app/node_modules/tslib/tslib.js:117:57)
 |        at fulfilled (/usr/src/my-app/node_modules/tslib/tslib.js:107:62)
 |        at process._tickCallback (internal/process/next_tick.js:68:7)
 |      message: 'Can\'t add new command when connection is in closed state',
 |      fatal: true,
 |      name: 'QueryFailedError',
 |      query: 'COMMIT',
 |      parameters: [] } }

With no reason, the underlying mysql connection seems to be closed. It seems related to connection pooling (see https://github.com/sidorares/node-mysql2/issues/939)

How can we fix that using typeorm ?

Issue Analytics

State:
Created 4 years ago
Comments:9

Top GitHub Comments

1reaction

Destreyfcommented, Jan 10, 2020

In the case you mentioned where you’re using a repository that’s from outside the transaction, yes that would cause issues.

You need to use the @TransactionRepository() in your method instead of your global one in the constructor as the repository likely isn’t bound to a pooled connection once it’s inside the connection manager.

See here: https://github.com/typeorm/typeorm/blob/master/docs/transactions.md#transaction-decorators

0reactions

daweedmcommented, Jan 11, 2020

@Destreyf No problem, thanks for your help !