Iceberg DROP table not removing data from s3

Hi, I am using presto (version 343) with Iceberg connector and found issue:

Tables which was created as CREATE TABLE ... or CREATE TABLE AS SELECT... then dropped - it will remove data only from Hive Metastore but not from s3. Then if we try to create same table again - we will have table already exists exception

Example:

CREATE TABLE iceberg.test_table (id varchar(25));
INSERT INTO iceberg.test_table values ('1');
DROP TABLE iceberg.test_table

-- Table removed from Hive metastore, but files still exists in s3

Note: In connector config we have hive.metastore.thrift.delete-files-on-drop=true

Issue investigation results

1. CREATE TABLE - when we create table (see HiveTableOperations), we have hardcoded TableType=EXTERNAL_TABLE and parameter (EXTERNAL = TRUE)

             Table.Builder builder = Table.builder()
                        ...
                        .setTableType(TableType.EXTERNAL_TABLE.name())
                        ...
                        .setParameter("EXTERNAL", "TRUE")
                        ...

1. DROP TABLE - we have 2 places which responsible for data deletion from s3 2.1 First one is Hive Metastore - it will delete files from EXTERNAL table only if we passed external.table.purge=TRUE parameter to it 2.2. Second place is ThriftHiveMetastore, but as we have hardcoded TableType=EXTERNAL_TABLE - this code will be skipped

  if (deleteFilesOnDrop && deleteData && isManagedTable(table) && !isNullOrEmpty(tableLocation)) {
                                deleteDirRecursive(hdfsContext, hdfsEnvironment, new Path(tableLocation));
                            }
#isManagedTable(table) -> false, because on table create we set tableType = EXTERNAL_TABLE

As a result data from s3 not deleted