Spring MVC custom argument resolvers order

See original GitHub issue

When I want to custom one argument Resolver in ： WebMvcConfigurerAdapter#addArgumentResolvers，and try to override parameter type of ServletRequest ; but I found it that caught low priority after ServletRequestMethodArgumentResolver (same parameter type of ServletRequest) ； review source RequestMappingHandlerAdapter#getDefaultArgumentResolvers discover below :

           `// Type-based argument resolution
	resolvers.add(new ServletRequestMethodArgumentResolver());
	resolvers.add(new ServletResponseMethodArgumentResolver());
	resolvers.add(new HttpEntityMethodProcessor(getMessageConverters()));
	resolvers.add(new RedirectAttributesMethodArgumentResolver());
	resolvers.add(new ModelMethodProcessor());
	resolvers.add(new MapMethodProcessor());
	resolvers.add(new ErrorsMethodArgumentResolver());
	resolvers.add(new SessionStatusMethodArgumentResolver());
	resolvers.add(new UriComponentsBuilderMethodArgumentResolver());

	// Custom arguments
	if (getCustomArgumentResolvers() != null) {
		resolvers.addAll(getCustomArgumentResolvers());
	}

I think that custom arguments resolver should be before the default argument ,so that can get highly priority to handle my logic; Thanks .

Issue Analytics

State:
Created 4 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

victorkevin2commented, May 29, 2019

In the end, I found an workaround. But I don’t think it’s the best

public class HttpRequestHandlerMethodArgumentResolver implements HandlerMethodArgumentResolver, InitializingBean   {
                                                                                            
        @Autowired
	private RequestMappingHandlerAdapter requestMappingHandlerAdapter;

	public void afterPropertiesSet() throws Exception {
		List<HandlerMethodArgumentResolver> argumentResolvers = requestMappingHandlerAdapter.getArgumentResolvers();
		List<HandlerMethodArgumentResolver> newArgumentResolvers = new LinkedList<>();
		newArgumentResolvers.add(this);
		newArgumentResolvers.addAll(argumentResolvers);
 requestMappingHandlerAdapter.setArgumentResolvers(Collections.unmodifiableList(newArgumentResovers));                                                                                                                                                                                                                                                                          
	}

0reactions

rstoyanchevcommented, May 29, 2019

Okay but just to be clear, the change I suggested in ServletRequestMethodArgumentResolver would have made your custom resolver work with the current order, because the built-in resolver would pass on any concrete request type it does not recognize.