Add Support for More R2DBC Pool Metrics

See original GitHub issue

The R2DBC connection pool metrics exposed by Actuator are currently very limited, we only get a few gauges about the current pool status as exposed by io.r2dbc.pool.PoolMetrics. Other important metrics like number and latency of connection acquire/allocation operations are missing.

I looked through the R2DBC ConnectionPool source code and found that the ConnectionFactory.Builder has a method to accept a reactor.pool.PoolMetricsRecorder, which can be used to track those metrics.

Would you consider integrating this with Actuator? It looks like it should be pretty straight-forward to implement a PoolMetricsRecorder that uses Micrometer’s MeterRegistry to track those metrics.

Issue Analytics

State:
Created a year ago
Reactions:1
Comments:9 (6 by maintainers)

Top GitHub Comments

1reaction

simonbaslecommented, Oct 11, 2022

this has been merged and released today in a new submodule of reactor/reactor-pool io.projectreactor.addons:reactor-pool-micrometer:0.1.0-RC1

1reaction

wilkinsonacommented, Sep 30, 2022

Thanks, @simonbasle. I think it would be good for @shakuzen, @jonatan-ivanov, @marcingrzejszczak to cast an expert eye over this.

Top Results From Across the Web

R2DBC Proxying Framework

R2DBC specifies two types of connection factory discovery, URL-based and Programmatic. R2DBC Proxy supports both with proxy as the driver ...

R2DBC pool closes all connections before each query

We added a metricsRecorder to the pool and, for debugging purposes, we're only printing when each method is invoked. It seems that before...

PoolMetrics (Reactive Relational Database Connectivity

An object that can be used to get live information about a ConnectionPool , suitable for gauge metrics. getXxx methods are configuration accessors, ......

Spring Data R2DBC - Reference Documentation

For most tasks, you should use R2dbcEntityTemplate or the repository support, which both use the rich mapping functionality. R2dbcEntityTemplate ...

R2DBC/r2dbc - Gitter

... crucial for adding more listeners, so we can track slow queries, expose metrics ... Hi,does spring data r2dbc DatabaseClient support select count...