Ability to close tooltips on Escape key

Hey! Thanks for a great package 💞 It vastly simplified me working with Popper and creating dropdowns!

One thing that’s kinda common for popovers/dropdowns is to close them on <kbd>escape</kbd> key. Could this fit into this package, you think?

The requirements could be something like:

Make it close on keydown event, with key <kbd>escape</kbd> as default.
Provide a way to opt out of the default behaviour (closeOnEscape: false as a passed prop).

I guess one can implement support for super custom cases here, like the ability for consumers to decide what DOM event and what key should trigger the close, but I think it’d be nice to keep it simple for now.

Let me know if I can help out with a PR.

I’ve implemented a quick fix in a fork of mine in the meantime, which code you can view here: https://github.com/brookback/react-popper-tooltip/pull/1.

Issue Analytics

State:
Created 5 years ago
Comments:8 (4 by maintainers)

Top GitHub Comments

2reactions

denisborovikovcommented, Sep 18, 2018

Thanks, I refactored the code after I pushed the comment but didn’t reload the page. Fixed now.

You’re right about the ref docs. @mohsinulhaq wasn’t clear enough. I didn’t understand this prop at all before I implemented the example above.

We can start the recipes from this case.

1reaction

denisborovikovcommented, Sep 19, 2018

We’re going to remove a ref part from README. To implement close on Esc feature external state with tooltipShown and onVisibilityChange should be used.

I will provide an example after #11 merged.