Auto login and nonce/state error question
See original GitHub issueI just upgraded to version 3.1 and i’m getting an error.
I’m not sure if this is applicable, but my site is configured to hit the domain, realize its insecure, then redirect to the login. (auto login)
In app.component.ts I’ve got this:
let self = this;
this.oauthService.configure(authConfig);
this.oauthService.setStorage(localStorage);
this.oauthService.tokenValidationHandler = new JwksValidationHandler();
this.oauthService.loadDiscoveryDocumentAndLogin().then((res) => {
self.oauthService.setupAutomaticSilentRefresh();
});
So, my request hits the domain name, heads off to identity server and comes back with the id_token hash then throws this error:
validating access_token failed. wrong state/nonce. null yey1KhuQ9ewceuY7Qpbic4sWg5UAt8BJ6YYNryuY
When i debugged through this, I noticed that the nonce was saved, then on the second trip, the nonce wasnt in the local storage any more. So the comparison is between a valid nonce and null.
I tried creating login options with disableOAuth2StateCheck, but that just kicked the can down the road a bit. I got the error
Error validating tokens Wrong nonce: 3BAgeBU3kWkX5EiDKFDaGThnWj6pYqmsAXpf2HSO
Here is the code I have now:
this.oauthService.configure(authConfig);
this.oauthService.setStorage(localStorage);
this.oauthService.tokenValidationHandler = new JwksValidationHandler();
let loginOptions = new LoginOptions();
loginOptions.disableOAuth2StateCheck = true;
this.oauthService.loadDiscoveryDocumentAndLogin(loginOptions).then((res) => {
if (res)
self.oauthService.setupAutomaticSilentRefresh();
});
EDIT: I was able to work around this error by using the disable state check as shown above and commenting out the other state check in node_modules/angular-oauth2-oidc/angular-oauth2-oidc.umd.js. Lines 1702 - 1706.
What would the fix be?
Issue Analytics
- State:
- Created 6 years ago
- Comments:26 (1 by maintainers)
Top Related StackOverflow Question
We were running into the same issue, and I think I’ve tracked down a repro. It’s quite reliable on my machine, but it does seem to be a timing issue or race condition, so the repro doesn’t always immediately work.
Repro
To reproduce:
ng servefor this branch in my sample repongto reload all windowsngto reload all windowsRinse and repeat step 7/8 until the issue arises, clearly visible in the dev tools console.
invalid_nonce_in_state, 1 of them runs just fineTruth be told, this is a very artificial repro, but it is the most reliable one I could make. Various posters above also mention the issue, and I myself encountered a hard-to-repro version of this issue when users close Chrome, reopen it, and try to restore multiple tabs at once. I presume my artificial repro resembles the real problem well enough.
Debug info
To create useful debug info, I am logging all OAuthEvent events and also
console.log(...)ing allStorageEvents where thekeyis'nonce'.Here’s a screenshot of a window that went bad, and the one that loaded just fine, side by side (other 2 windows that went bad not shown):
Here’s a rather large animated gif that shows this in full effect (when my mouse goes off-screen I go to VSCode to save a file and trigger
ng’s hot-reloading):Hypothesis
I speculate that the issue arises because the nonce state check will
validateNonceForAccessTokenagainst thethis._storage.getItem('nonce')which might’ve been changed in the mean time by another window/tab in the same browser.I don’t think the browser or type of storage are the root cause of this issue. It is quite possible though that they affect the issue, as they might have different kinds of multi-threading, e.g. deciding to give larger chunks of CPU time to one tab at a time, hiding the actual issue.
Solution
Not really a clue. Perhaps the
this._storage.getItem('nonce')call should be done earlier on and passed to thevalidateNonceForAccessToken(...)call instead?Workarounds
In my sample repository, the
masterbranch does have the errors, but that doesn’t seem to hurt too much, because:tryLogin(...)call that fails, and I chain a call to asilentRefresh(...)right after that, which logs the user in (after a small delay) after allStorageEvents aroundaccess_tokento change the logged in state (so other tabs that successfully log in communicate this effectively to their peers)But then again, it’s merely a sample repository, not really battle-tested. But perhaps it helps someone.
For what it’s worth, here’s a shortened version of my current login flow:
Resolution of this issue, at least for us. It turns out that our server had the redirects deleted. When people used the HTTP address they were not redirected to the HTTPS address before starting the authentication process. The authentication process would start in HTTP and save the NONCE in the corresponding local/session storage. The redirect url parameter used was always HTTPS so upon authentication the user was redirected to the HTTPS address and would not find the NONCE in storage.
Once we corrected the server redirect to HTTPS://www.somesite.com/ our NONCE issue disappears as we found it in local storage.