[react/no-unknown-property] rule conflicts with `@react-three/fiber` on `<mesh />` and other tags
See original GitHub issueI’m using @react-three/fiber in my app, and updating eslint-plugin-react broke the linting.
You did not took into account custom renderers while introducing this changes.
on <mesh /> false negatives:
Unknown property ‘castShadow’ found Unknown property ‘receiveShadow’ found Unknown property ‘dispose’ found Unknown property ‘geometry’ found Unknown property ‘userData’ found Unknown property ‘rotation’ found
on <meshStandardMaterial /> false negatives:
Unknown property ‘metalness’ found Unknown property ‘roughness’ found Unknown property ‘side’ found
on <planeBufferGeometry />
Unknown property ‘args’ found
on <meshPhongMaterial />
Unknown property ‘flatShading’ found Unknown property ‘shininess’ found Unknown property ‘side’ found Unknown property ‘specular’ found
and a lot more.
Please fix support for @react-three/fiber
Meanwhile I had to disable react/no-unknown-property rule
Issue Analytics
- State:
- Created a year ago
- Reactions:8
- Comments:21 (9 by maintainers)
Top Related StackOverflow Question
The HTML standard says they shouldn’t, and it’s the authority on that.
@CodyJasonBennett I’m not sure what you mean. Anything lowercased either conforms to the html standard or is invalid, incorrect, and bad - that’s just the way react works.