Angular 10: Class is using Angular features but is not decorated

I am trying to use this library with Angular 10. I get the following error when I try to build the Angular project:

src/directives/generated/value-accessor.ts:4:14 - error NG2007: Class is using Angular features but is not decorated. Please add an explicit Angular decorator.

4 export class ValueAccessor implements ControlValueAccessor {

This new behaviour seems to have been introduced by https://github.com/angular/angular/pull/36921.

Manually appending @Directive() to ValueAccessor fixes the issue:

import {Directive, ElementRef, HostListener} from '@angular/core';
import { ControlValueAccessor } from '@angular/forms';

@Directive()
export class ValueAccessor implements ControlValueAccessor {
// ...

I wanted to create a pull request for that, but @Directive changed between Angular 9 and Angular 10. In Angular 9, @Directive() requires a selector attribute, while in Angular 10, you can pass it without any option.

So maybe Stencil needs to be aware of the Angular version effectively used?

Issue Analytics

State:
Created 3 years ago
Reactions:9
Comments:8

Top GitHub Comments

14reactions

avchugaevcommented, Jan 16, 2021

For me it occurs on an abstract class.

Same story…

Angular team, please let us write normal abstract/base classes. This limitation looks ridiculous. It forces me to decorate my abstract class just because it implements OnDestroy interface.

And even more, compiler emits this error only in normal mode. When I run the prod build, everything’s fine.

@Injectable() // 👈 I have to add this for no real reason to satisfy the compiler. why?!
export abstract class LocalStore<TState> extends StoreBase<TState> implements OnDestroy {
  ngOnDestroy(): void {
    this.complete();
  }
}

8reactions

Hamckercommented, Oct 27, 2020

For me it occurs on an abstract class.