excludeHostsForProxy setting doesn't work in the last version

Hi and thank you for you great job on this extension!

I found a potential issue in the last version (0.20.2) related to the excludeHostsForProxy setting, it seems to be ignored.

I tried to uninstall the new version in favour of an old one (0.19.0) and with the old version the setting works properly.

Has anything changed in the settings’ definition in the last release?

Steps to reproduce the error:

Being behind a proxy
Set proxy in VS Code
Run a webservice locally
Update excludeHostsForProxy setting like this: "rest-client.excludeHostsForProxy": ["localhost"]
Make a request to your webservice (i.e. GET http://localhost:8080) -> Receive: Proxy Error response

Thank you, Federico

Issue Analytics

State:
Created 5 years ago
Comments:13 (7 by maintainers)

Top GitHub Comments

1reaction

Huachaocommented, Oct 23, 2018

@Fed29 Thanks for your feedback, I have fixed the inconsistent behavior and will publish this fix in next release.

1reaction

Fed29commented, Oct 22, 2018

Yes @Huachao , exactly but only in the case you use the “rest-client.excludeHostsForProxy” setting.

Please, try the test I posted earlier:

VSCode Settings:

{
    "http.proxy": "http://not-exists-2:8080",
    "http.proxyStrictSSL": false,
    "rest-client.excludeHostsForProxy": ["127.0.0.1"]
}

Env Variables (restart VSCode after the edit)

HTTP_PROXY = "http://not-exists-1:8080"
NO_PROXY = localhost

At this point the VSCode proxy should be “http://not-exists-2:8080”, do you agree?

Send the request to GET http://127.0.0.1:50201 and it shouldn’t use proxy, right?

But you will receive an error like “ERROR: getaddrinfo ENOTFOUND not-exists1 not-exists1:8080” this means the extension try to use the proxy in the env variable, that should be “overrided” by the VSCode proxy setting and excluded by the “rest-client.excludeHostsForProxy” setting.