-e/--exclude doesn't work with pre-commit

Environment

interrogate version: 1.3.1
Operating System(s): Windows
Python version(s): 3.7.7

Description of the bug

Using the -e/--exclude argument works perfectly fine when using interrogate directly on the command line. However, when I pass it in my .pre-commit-config.yaml file like so:

- repo: https://github.com/econchick/interrogate
      rev: 1.3.1 # or master if you're bold
      hooks:
          - id: interrogate
            args: [--exclude=tests, --fail-under=100]

The argument doesn’t seem to take effect. So far, I have resulted to using --ignore-regex which does work and achieves the same goal. Still, strange that --exclude doesn’t seem to work. Maybe I am doing something wrong?

What you expected to happen

I expected --exclude to work using pre-commit.

Issue Analytics

State:
Created 3 years ago
Comments:9 (4 by maintainers)

Top GitHub Comments

14reactions

s-weigandcommented, Nov 29, 2020

My solution is adding pass_filenames to the hook

  - repo: https://github.com/econchick/interrogate
    rev: 1.3.2
    hooks:
      - id: interrogate
        args: [-vv, --config=pyproject.toml]
        pass_filenames: false

That way interrogate runs as if you were running it from CLI.

Maybe this should be part of the defaults for the hook?

2reactions

econchickcommented, Oct 13, 2020

Seems like a reasonable expectation 😃 Thanks for the issue! I’ll try to set some time aside over the next week to look deeper into this.