Make it easier to mock DbSet.Add

##upgrading from EF Core 5.0.2 to 6.0.1 making Nunit unit test to fail

Currently I have upgraded from .net core 5 to .net 6, so I also have to update ef core from 5 to 6.0.1. However doing this is failing some of my unit test written in nunit and using Moq. Issue is occuring while mocking ‘InternalEntityEntry’ class which is sealed in 6.0.1 but abstract in 5.0.2.

Below is the code that I am using to create Moq:

var entry = new Mock<InternalEntityEntry>(new Mock<IStateManager>().Object,
                new EntityType(typeof(T), new Model(), true, ConfigurationSource.Explicit)).Object;
            var entityEntry = new Mock<EntityEntry<T>>(entry);
            entityEntry.SetupGet(self => self.Entity).Returns(data);
            mockSet.Setup(d => d.AddAsync(It.IsAny<T>(), default)).Returns(() => new ValueTask<EntityEntry<T>>(entityEntry.Object));

and below is the error received:

System.NotSupportedException : Type to mock (InternalEntityEntry) must be an interface, a delegate, or a non-sealed, non-static class.

Help me in resolving this.

Include provider and version information

EF Core version: 6.0.1 Database provider: Microsoft.EntityFrameworkCore.SqlServer Target framework: .NET 6.0 Operating system: IDE: Visual Studio 2022

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:10 (6 by maintainers)

Top GitHub Comments

9reactions

ajcvickerscommented, Jan 10, 2022

@roji It is not required that InternalEntityEnrtry be mocked for this. For example:

var internalEntityEntry = new InternalEntityEntry(
    new Mock<IStateManager>().Object,
    new RuntimeEntityType("T", typeof(T), false, null, null, null, ChangeTrackingStrategy.Snapshot, null, false),
    data);

var entityEntry = new Mock<EntityEntry<T>>(internalEntityEntry);

That being said, EntityEntry<T> is not easy to mock. At the time we considered it something that people shouldn’t do, but I don’t think that took into account that methods like Add would return one. (In EF6, we returned just the instance, not the entry.)

2reactions

rojicommented, Jan 5, 2022

@RitikaPoddar mocking an internal EF type is not something that should be done in application testing - by definition these types don’t represent the public API of the library, may change at any moment and should not be needed.

Can you provide more context on exactly what you’re trying to test, and provide the code for the entire test? We may be able to provide a better approach to doing that testing.