TamperMonkey userscript not working

See original GitHub issue

This was working, but it looks like Google have changed their page causing the script to fail when trying to add the button.

Example link: https://www.google.co.uk/search?q=sega+power+strip&num=40&tbm=isch

Output from console:

Uncaught TypeError: Cannot set property 'innerText' of null
    at addButton (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:51)
    at addedNodes.forEach (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:81)
    at NodeList.forEach (<anonymous>)
    at mutations.forEach (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:80)
    at Array.forEach (<anonymous>)
    at MutationObserver (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:77)

Issue Analytics

State:
Created 6 years ago
Reactions:1
Comments:8 (2 by maintainers)

Top GitHub Comments

2reactions

jeffrzcommented, Mar 12, 2018

It looks like when openButton is cloned in the extension, it no longer contains the class “._WKw”. This makes the querySelector call return a null result which kills the innerText property access. Adjusting the querySelector ought to fix it.

When I recompiled the extension with the line changed to “button.querySelector(‘a’).innerText = localizedViewImage;” it worked just fine.

1reaction

devuntcommented, Mar 17, 2018

Fixed by #66.